Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate

chrome/browser/ui/views/toolbar/browser_actions_container.cc

Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index 90ed0b1ece5b86fd4830b301b698f69bc1a5024a..ec72cdb5759694ec42addbff2ae9f3369198bcbe 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -328,10 +328,10 @@ void BrowserActionsContainer::ShowToolbarActionBubble(
 
   ToolbarActionsBarBubbleViews* bubble =
       new ToolbarActionsBarBubbleViews(anchor_view, std::move(controller));
-  views::BubbleDelegateView::CreateBubble(bubble);
-  active_bubble_ = bubble;
-  active_bubble_->GetWidget()->AddObserver(this);
+  views::BubbleDialogDelegateView::CreateBubble(bubble);
+  bubble->GetWidget()->AddObserver(this);
   bubble->Show();
+  active_bubble_ = bubble;

[Devlin, 2016/04/13 22:36:53]

nit: I seem to recall once running into some edge case where we could call
Show() and the bubble would try to show and close synchronously.  If that
happens, this will be wrong.  Can we put the active_bubble_ assignment back
above Show() so that if everything happens in one quick burst, we still track it
correctly?

(Or, if you're certain this is no longer a concern, that's fine too.)

[Evan Stade, 2016/04/14 00:37:08]

Done.

 }
 
 void BrowserActionsContainer::OnWidgetClosing(views::Widget* widget) {