Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate

chrome/browser/ui/views/toolbar/browser_actions_container.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
 
 #include <utility>
 
 #include "base/compiler_specific.h"
 #include "base/stl_util.h"
@@ skipping 310 matching lines @@
       anchor_view = BrowserView::GetBrowserViewForBrowser(browser_)
                         ->toolbar()
                         ->app_menu_button();
     }
   } else {
     anchor_view = this;
   }
 
   ToolbarActionsBarBubbleViews* bubble =
       new ToolbarActionsBarBubbleViews(anchor_view, std::move(controller));
-  views::BubbleDelegateView::CreateBubble(bubble);
+  views::BubbleDialogDelegateView::CreateBubble(bubble);
+  bubble->GetWidget()->AddObserver(this);
+  bubble->Show();
   active_bubble_ = bubble;

[Devlin, 2016/04/13 22:36:53]

nit: I seem to recall once running into some edge case where we could call
Show() and the bubble would try to show and close synchronously.  If that
happens, this will be wrong.  Can we put the active_bubble_ assignment back
above Show() so that if everything happens in one quick burst, we still track it
correctly?

(Or, if you're certain this is no longer a concern, that's fine too.)

[Evan Stade, 2016/04/14 00:37:08]

Done.

-  active_bubble_->GetWidget()->AddObserver(this);
-  bubble->Show();
 }
 
 void BrowserActionsContainer::OnWidgetClosing(views::Widget* widget) {
   ClearActiveBubble(widget);
 }
 
 void BrowserActionsContainer::OnWidgetDestroying(views::Widget* widget) {
   ClearActiveBubble(widget);
 }
 
@@ skipping 403 matching lines @@
       views::Painter::CreateImageGridPainter(kWarningImages));
 }
 
 void BrowserActionsContainer::ClearActiveBubble(views::Widget* widget) {
   DCHECK(active_bubble_);
   DCHECK_EQ(active_bubble_->GetWidget(), widget);
   widget->RemoveObserver(this);
   active_bubble_ = nullptr;
   toolbar_actions_bar_->OnBubbleClosed();
 }