Issue 1877043003: [EXPERIMENT] MacViews: Implement Tab Dragging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1877043003: [EXPERIMENT] MacViews: Implement Tab Dragging

Created:
4 years, 8 months ago by tapted

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, tfarina, cc-bugs_chromium.org, dcheng

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[EXPERIMENT] MacViews: Implement Tab Dragging Baseline CL from https://codereview.chromium.org/1747803003/ plus experiments Description: BridgedNativeWidget::RunMoveLoop() drags the window using the WindowServer, as such the window could be dragged between Spaces. Most of the tests in tab_drag_controller_interactive_uitest.cc pass, and I've added several Mac-specific ones to test for the edge cases. BUG=594079 COLLABORATOR=tapted@chromium.org Also reviewed in http://crrev.com/1259913003/ patch from issue 1747803003 at patchset 200001 (http://crrev.com/1747803003#ps200001)

Patch Set 1 #

Patch Set 2 : Fix build at HEAD #

Patch Set 3 : Lots of fixes from review #

Patch Set 4 : git cl format #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1362 lines, -66 lines)			Patch
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc	View	1 2	12 chunks	+213 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/window_finder_mac.mm	View		1 chunk	+25 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/BUILD.gn	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/test/base/interactive_test_utils.h	View	1 2 3	2 chunks	+54 lines, -4 lines	0 comments	Download
M	chrome/test/base/interactive_test_utils_mac.mm	View	1 2 3	2 chunks	+267 lines, -0 lines	0 comments	Download
M	ui/base/test/ui_controls.h	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	ui/base/test/ui_controls_mac.mm	View	1 2 3	9 chunks	+281 lines, -29 lines	0 comments	Download
M	ui/gfx/geometry/rect.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/gfx/geometry/rect.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	ui/gfx/geometry/rect_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	ui/views/cocoa/bridged_content_view.h	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/views/cocoa/bridged_content_view.mm	View		5 chunks	+23 lines, -1 line	0 comments	Download
M	ui/views/cocoa/bridged_native_widget.h	View		7 chunks	+18 lines, -0 lines	0 comments	Download
M	ui/views/cocoa/bridged_native_widget.mm	View	1 2 3	8 chunks	+99 lines, -10 lines	0 comments	Download
A	ui/views/cocoa/cocoa_window_move_loop.h	View	1 2	1 chunk	+58 lines, -0 lines	0 comments	Download
A	ui/views/cocoa/cocoa_window_move_loop.mm	View	1 2 3	1 chunk	+190 lines, -0 lines	0 comments	Download
M	ui/views/cocoa/views_nswindow_delegate.mm	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_mac.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_mac.mm	View	1 2 3	3 chunks	+45 lines, -6 lines	0 comments	Download