Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add disconnection message and unit-tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/create_blimp_message_unittest.cc
diff --git a/blimp/common/create_blimp_message_unittest.cc b/blimp/common/create_blimp_message_unittest.cc
index d2b57dc5488ad63b68cb4830e1867dd8735a1174..123cf98956617b69b39e08ac7615dbaaa9ff62e7 100644
--- a/blimp/common/create_blimp_message_unittest.cc
+++ b/blimp/common/create_blimp_message_unittest.cc
@@ -91,5 +91,29 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {
message->protocol_control().start_connection().protocol_version());
}
+TEST(CreateBlimpMessageTest, EndConnectionMessage) {
+ std::unique_ptr<BlimpMessage> message =
+ CreateEndConnectionMessage(EndConnectionMessage::PROTOCOL_MISMATCH);
+ EXPECT_NE(nullptr, message);
Kevin M 2016/04/22 21:12:54 ASSERT_NE for null checks?
+ EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type());
+ EXPECT_EQ(ProtocolControlMessage::END_CONNECTION,
+ message->protocol_control().type());
+ EXPECT_EQ(EndConnectionMessage::PROTOCOL_MISMATCH,
+ message->protocol_control().end_connection().reason());
+}
+
+TEST(CreateBlimpMessageTest, CheckpointAckMessage) {
+ const int64_t kTestCheckpointId = 1;
+
+ std::unique_ptr<BlimpMessage> message =
+ CreateCheckpointAckMessage(kTestCheckpointId);
+ EXPECT_NE(nullptr, message);
+ EXPECT_EQ(BlimpMessage::PROTOCOL_CONTROL, message->type());
+ EXPECT_EQ(ProtocolControlMessage::CHECKPOINT_ACK,
+ message->protocol_control().type());
+ EXPECT_EQ(kTestCheckpointId,
+ message->protocol_control().checkpoint_ack().checkpoint_id());
+}
+
} // namespace
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698