blimp/common/BUILD.gn - Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/BUILD.gn

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add disconnection message and unit-tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/session/assignment_source_unittest.cc ('k') | blimp/common/create_blimp_message.h » ('j') | blimp/common/create_blimp_message_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/common/BUILD.gn

diff --git a/blimp/common/BUILD.gn b/blimp/common/BUILD.gn

index 6548853d326066e0c8770e17d68e2f201996de1f..66263ac4280cf1aff8b6d1714657aeb57686ceac 100644

--- a/blimp/common/BUILD.gn

+++ b/blimp/common/BUILD.gn

@@ -3,6 +3,7 @@

# found in the LICENSE file.

import("//testing/test.gni")

Kevin M 2016/04/22 21:12:54 Alphabetic order for imports?

+import("//chrome/version.gni")

component("blimp_common") {

sources = [

@@ -22,12 +23,13 @@ component("blimp_common") {

"create_blimp_message.h",

"logging.cc",

"logging.h",

- "protocol_version.h",

+ "version_info.h",

Kevin M 2016/04/22 21:12:54 Are we missing version_info.cc?

]

defines = [ "BLIMP_COMMON_IMPLEMENTATION=1" ]

deps = [

+ ":generate_version_info",

"//base",

"//blimp/common/proto",

"//cc",

@@ -54,3 +56,8 @@ source_set("unit_tests") {

"//testing/gtest",

]

}

+process_version("generate_version_info") {

+ template_file = "version_info.cc.version"

+ output = "$target_gen_dir/version_info.cc"

« no previous file with comments | « blimp/client/session/assignment_source_unittest.cc ('k') | blimp/common/create_blimp_message.h » ('j') | blimp/common/create_blimp_message_unittest.cc » ('J')