blimp/client/session/assignment_source.cc - Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/assignment_source.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android to use GetVersionNumber() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/app/android/blimp_client_session_android.cc ('k') | blimp/client/session/assignment_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/session/assignment_source.cc

diff --git a/blimp/client/session/assignment_source.cc b/blimp/client/session/assignment_source.cc

index 2a08376b59ae504baf4eaa180cf7621432301570..efcb8b6eca7b021114907968d7bd236b782d8a73 100644

--- a/blimp/client/session/assignment_source.cc

+++ b/blimp/client/session/assignment_source.cc

@@ -243,7 +243,8 @@ void AssignmentSource::QueryAssigner(const std::string& client_auth_token) {

// Write the JSON for the request data.

base::DictionaryValue dictionary;

- dictionary.SetString(kProtocolVersionKey, blimp::kEngineVersion);

+ dictionary.SetString(kProtocolVersionKey,

+ base::IntToString(kProtocolVersion));

std::string json;

base::JSONWriter::Write(dictionary, &json);

url_fetcher_->SetUploadData("application/json", json);

« no previous file with comments | « blimp/client/app/android/blimp_client_session_android.cc ('k') | blimp/client/session/assignment_source_unittest.cc » ('j') | no next file with comments »