Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: blimp/client/app/android/blimp_client_session_android.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android to use GetVersionNumber() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/DEPS ('k') | blimp/client/session/assignment_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/android/blimp_client_session_android.cc
diff --git a/blimp/client/app/android/blimp_client_session_android.cc b/blimp/client/app/android/blimp_client_session_android.cc
index 1c4b44c3600bea54b1569a0fbf138b2d55dde575..4da362e18ee490103424d23b4b1a4a48a5174a97 100644
--- a/blimp/client/app/android/blimp_client_session_android.cc
+++ b/blimp/client/app/android/blimp_client_session_android.cc
@@ -13,7 +13,7 @@
#include "blimp/client/feature/settings_feature.h"
#include "blimp/client/feature/tab_control_feature.h"
#include "blimp/client/session/assignment_source.h"
-#include "blimp/common/protocol_version.h"
+#include "components/version_info/version_info.h"
#include "jni/BlimpClientSession_jni.h"
#include "net/base/net_errors.h"
@@ -109,7 +109,9 @@ void BlimpClientSessionAndroid::OnAssignmentConnectionAttempted(
Java_BlimpClientSession_onAssignmentReceived(
env, java_obj_.obj(), static_cast<jint>(result),
base::android::ConvertUTF8ToJavaString(env, engine_ip).obj(),
- base::android::ConvertUTF8ToJavaString(env, blimp::kEngineVersion).obj());
+ base::android::ConvertUTF8ToJavaString(env,
+ version_info::GetVersionNumber())
+ .obj());
BlimpClientSession::OnAssignmentConnectionAttempted(result, assignment);
}
« no previous file with comments | « blimp/client/DEPS ('k') | blimp/client/session/assignment_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698