Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3708)

Unified Diff: blimp/common/create_blimp_message.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Route EndConnection to OnConnectionError notifications Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/create_blimp_message.cc
diff --git a/blimp/common/create_blimp_message.cc b/blimp/common/create_blimp_message.cc
index 460560c6851c6513ff1ebf32150a5e3de6f8ebd6..14595f3cb44658bb1e132788818faf52acdcba2a 100644
--- a/blimp/common/create_blimp_message.cc
+++ b/blimp/common/create_blimp_message.cc
@@ -65,7 +65,6 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(
}
std::unique_ptr<BlimpMessage> CreateBlimpMessage(SizeMessage** size_message) {
- DCHECK(size_message);
TabControlMessage* control_message;
std::unique_ptr<BlimpMessage> output = CreateBlimpMessage(&control_message);
control_message->mutable_size();
@@ -101,8 +100,6 @@ std::unique_ptr<BlimpMessage> CreateCheckpointAckMessage(
std::unique_ptr<BlimpMessage> output(new BlimpMessage);
ProtocolControlMessage* control_message = output->mutable_protocol_control();
- control_message->mutable_checkpoint_ack();
-
CheckpointAckMessage* checkpoint_ack_message =
control_message->mutable_checkpoint_ack();
checkpoint_ack_message->set_checkpoint_id(checkpoint_id);
@@ -110,4 +107,16 @@ std::unique_ptr<BlimpMessage> CreateCheckpointAckMessage(
return output;
}
+std::unique_ptr<BlimpMessage> CreateEndConnectionMessage(
+ EndConnectionMessage::Reason reason) {
+ std::unique_ptr<BlimpMessage> output(new BlimpMessage);
+
+ ProtocolControlMessage* control_message = output->mutable_protocol_control();
+ EndConnectionMessage* end_connection_message =
+ control_message->mutable_end_connection();
+ end_connection_message->set_reason(reason);
+
+ return output;
+}
+
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698