Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: blimp/common/create_blimp_message_unittest.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Route EndConnection to OnConnectionError notifications Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/create_blimp_message_unittest.cc
diff --git a/blimp/common/create_blimp_message_unittest.cc b/blimp/common/create_blimp_message_unittest.cc
index 063eed58aadbc90889a28a89508e579f9a5f6b9b..119f581c493aea7b4c14dd525f8197b66066f373 100644
--- a/blimp/common/create_blimp_message_unittest.cc
+++ b/blimp/common/create_blimp_message_unittest.cc
@@ -20,7 +20,6 @@ TEST(CreateBlimpMessageTest, CompositorMessage) {
CompositorMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details, kTabId);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_compositor());
EXPECT_EQ(kTabId, message->target_tab_id());
}
@@ -29,7 +28,6 @@ TEST(CreateBlimpMessageTest, TabControlMessage) {
TabControlMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_tab_control());
}
@@ -37,7 +35,6 @@ TEST(CreateBlimpMessageTest, InputMessage) {
InputMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_input());
}
@@ -45,7 +42,6 @@ TEST(CreateBlimpMessageTest, NavigationMessage) {
NavigationMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details, kTabId);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_navigation());
EXPECT_EQ(kTabId, message->target_tab_id());
}
@@ -54,7 +50,6 @@ TEST(CreateBlimpMessageTest, RenderWidgetMessage) {
RenderWidgetMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details, kTabId);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_render_widget());
EXPECT_EQ(kTabId, message->target_tab_id());
}
@@ -63,7 +58,6 @@ TEST(CreateBlimpMessageTest, SizeMessage) {
SizeMessage* details = nullptr;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(TabControlMessage::kSize,
message->mutable_tab_control()->tab_control_case());
EXPECT_EQ(details, message->mutable_tab_control()->mutable_size());
@@ -73,7 +67,6 @@ TEST(CreateBlimpMessageTest, EngineSettingsMessage) {
EngineSettingsMessage* details;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&details);
EXPECT_NE(nullptr, details);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(details, message->mutable_settings()->mutable_engine_settings());
}
@@ -82,7 +75,6 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {
const int protocol_version = 1;
std::unique_ptr<BlimpMessage> message =
CreateStartConnectionMessage(client_token, protocol_version);
- EXPECT_NE(nullptr, message);
EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());
EXPECT_EQ(ProtocolControlMessage::kStartConnection,
message->protocol_control().connection_message_case());
@@ -92,5 +84,27 @@ TEST(CreateBlimpMessageTest, StartConnectionMessage) {
message->protocol_control().start_connection().protocol_version());
}
+TEST(CreateBlimpMessageTest, EndConnectionMessage) {
+ std::unique_ptr<BlimpMessage> message =
+ CreateEndConnectionMessage(EndConnectionMessage::PROTOCOL_MISMATCH);
+ EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());
+ EXPECT_EQ(ProtocolControlMessage::kEndConnection,
+ message->protocol_control().connection_message_case());
+ EXPECT_EQ(EndConnectionMessage::PROTOCOL_MISMATCH,
+ message->protocol_control().end_connection().reason());
+}
+
+TEST(CreateBlimpMessageTest, CheckpointAckMessage) {
+ const int64_t kTestCheckpointId = 1;
+
+ std::unique_ptr<BlimpMessage> message =
+ CreateCheckpointAckMessage(kTestCheckpointId);
+ EXPECT_EQ(BlimpMessage::kProtocolControl, message->feature_case());
+ EXPECT_EQ(ProtocolControlMessage::kCheckpointAck,
+ message->protocol_control().connection_message_case());
+ EXPECT_EQ(kTestCheckpointId,
+ message->protocol_control().checkpoint_ack().checkpoint_id());
+}
+
} // namespace
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698