Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876903002: [v8] Fix Chrome's "Experimental JavaScript" switch. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Fix Chrome's "Experimental JavaScript" switch. BUG=chromium:602336 LOG=Y Committed: https://crrev.com/75fddc14b864457d77fff8244e3835131435cb89 Cr-Commit-Position: refs/heads/master@{#386675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -45 lines) Patch
M chrome/common/chrome_switches.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 4 chunks +0 lines, -32 lines 0 comments Download
M content/public/common/content_switches.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/render_process_impl.cc View 3 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876903002/1
4 years, 8 months ago (2016-04-11 17:21:42 UTC) #2
Igor Sheludko
PTAL. I would like to fix tests that call v8::V8::SetFlagsFromString() in a separate CL.
4 years, 8 months ago (2016-04-11 17:44:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 18:29:34 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-12 13:06:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876903002/1
4 years, 8 months ago (2016-04-12 13:58:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 14:03:24 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:04:45 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/75fddc14b864457d77fff8244e3835131435cb89
Cr-Commit-Position: refs/heads/master@{#386675}

Powered by Google App Engine
This is Rietveld 408576698