Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4540)

Unified Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 1876903002: [v8] Fix Chrome's "Experimental JavaScript" switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_process_observer.cc
diff --git a/chrome/renderer/chrome_render_process_observer.cc b/chrome/renderer/chrome_render_process_observer.cc
index 891c6bcf64e2b98e9255ae0109e9458355c15c1c..3f6fcb2eca96332d247b32aecf36dfe5723c9f3b 100644
--- a/chrome/renderer/chrome_render_process_observer.cc
+++ b/chrome/renderer/chrome_render_process_observer.cc
@@ -13,7 +13,6 @@
#include "base/base_switches.h"
#include "base/bind.h"
#include "base/command_line.h"
-#include "base/feature_list.h"
#include "base/files/file_util.h"
#include "base/location.h"
#include "base/macros.h"
@@ -29,7 +28,6 @@
#include "build/build_config.h"
#include "chrome/common/child_process_logging.h"
#include "chrome/common/chrome_paths.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/media/media_resource_provider.h"
#include "chrome/common/net/net_resource_provider.h"
#include "chrome/common/render_messages.h"
@@ -235,28 +233,6 @@ void CreateResourceUsageReporter(
new ResourceUsageReporterImpl(observer, std::move(request));
}
-const base::Feature kV8_ES2015_TailCalls_Feature {
- "V8_ES2015_TailCalls", base::FEATURE_DISABLED_BY_DEFAULT
-};
-
-const base::Feature kV8SerializeEagerFeature{"V8_Serialize_Eager",
- base::FEATURE_DISABLED_BY_DEFAULT};
-
-const base::Feature kV8SerializeAgeCodeFeature{
- "V8_Serialize_Age_Code", base::FEATURE_DISABLED_BY_DEFAULT};
-
-void SetV8FlagIfFeature(const base::Feature& feature, const char* v8_flag) {
- if (base::FeatureList::IsEnabled(feature)) {
- v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag));
- }
-}
-
-void SetV8FlagIfHasSwitch(const char* switch_name, const char* v8_flag) {
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(switch_name)) {
- v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag));
- }
-}
-
} // namespace
bool ChromeRenderProcessObserver::is_incognito_process_ = false;
@@ -270,14 +246,6 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver()
WebRuntimeFeatures::enableRequestAutocomplete(true);
#endif
- SetV8FlagIfFeature(kV8_ES2015_TailCalls_Feature, "--harmony-tailcalls");
- SetV8FlagIfFeature(kV8SerializeEagerFeature, "--serialize_eager");
- SetV8FlagIfFeature(kV8SerializeAgeCodeFeature, "--serialize_age_code");
- SetV8FlagIfHasSwitch(switches::kDisableJavaScriptHarmonyShipping,
- "--noharmony-shipping");
- SetV8FlagIfHasSwitch(switches::kJavaScriptHarmony, "--harmony");
- SetV8FlagIfHasSwitch(switches::kEnableWasm, "--expose-wasm");
-
RenderThread* thread = RenderThread::Get();
resource_delegate_.reset(new RendererResourceDelegate());
thread->SetResourceDispatcherDelegate(resource_delegate_.get());
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698