Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5896)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 18769009: [Activity Log] fix logging of blocked API calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed a logging statement Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 1f80d785f10daff9187da28e7215957bed90f6b6..719f8b66d070c063255ea42f43cca9826da98aaa 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -1442,6 +1442,13 @@ bool Dispatcher::CheckContextAccessToExtensionAPI(
Feature::Availability availability = context->GetAvailability(function_name);
if (!availability.is_available()) {
+ Feature::AvailabilityResult result = availability.result();
+ if (result != Feature::INVALID_MIN_MANIFEST_VERSION &&
+ result != Feature::INVALID_MAX_MANIFEST_VERSION &&
+ result != Feature::UNSUPPORTED_CHANNEL) {
not at google - send to devlin 2013/07/11 19:22:33 these flags seem a bit arbitrary, is there any cha
felt 2013/07/12 01:53:04 Done.
+ APIActivityLogger::LogBlockedCall(context->extension()->id(),
+ function_name);
+ }
v8::ThrowException(v8::Exception::Error(
v8::String::New(availability.message().c_str())));
}

Powered by Google App Engine
This is Rietveld 408576698