[Activity Log] fix logging of blocked API calls

chrome/renderer/extensions/dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
 #include "base/json/json_reader.h"
@@ skipping 1424 matching lines @@
     static const char kMessage[] =
         "%s cannot be used within a sandboxed frame.";
     std::string error_msg = base::StringPrintf(kMessage, function_name.c_str());
     v8::ThrowException(
         v8::Exception::Error(v8::String::New(error_msg.c_str())));
     return false;
   }
 
   Feature::Availability availability = context->GetAvailability(function_name);
   if (!availability.is_available()) {
+    Feature::AvailabilityResult result = availability.result();
+    if (result != Feature::INVALID_MIN_MANIFEST_VERSION &&
+        result != Feature::INVALID_MAX_MANIFEST_VERSION &&
+        result != Feature::UNSUPPORTED_CHANNEL) {

[not at google - send to devlin, 2013/07/11 19:22:33]

these flags seem a bit arbitrary, is there any chance you can do the filtering
in LogBlockedCall instead?

[felt, 2013/07/12 01:53:04]

Done.

+      APIActivityLogger::LogBlockedCall(context->extension()->id(),
+                                        function_name);
+    }
     v8::ThrowException(v8::Exception::Error(
         v8::String::New(availability.message().c_str())));
   }
 
   return availability.is_available();
 }
 
 void Dispatcher::DispatchEvent(const std::string& extension_id,
                                const std::string& event_name) const {
   base::ListValue args;
@@ skipping 40 matching lines @@
     RenderView* background_view =
         ExtensionHelper::GetBackgroundPage(extension_id);
     if (background_view) {
       background_view->Send(new ExtensionHostMsg_EventAck(
           background_view->GetRoutingID()));
     }
   }
 }
 
 }  // namespace extensions