third_party/WebKit/Source/modules/webmidi/MIDIAccess.h - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

index acc04a0fac8bdfdb3ca8389942ab33289b85c013..d26173ba821f8e762bdbf5c9acc1e49ad6c293c0 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

@@ -53,6 +53,7 @@ class MIDIAccess final : public RefCountedGarbageCollectedEventTargetWithInlineD

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MIDIAccess);

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(MIDIAccess);

+ USING_PRE_FINALIZER(MIDIAccess, dispose);

public:

static MIDIAccess* create(PassOwnPtr<MIDIAccessor> accessor, bool sysexEnabled, const Vector<MIDIAccessInitializer::PortDescriptor>& ports, ExecutionContext* executionContext)

{

@@ -99,11 +100,11 @@ public:

// Eager finalization needed to promptly release m_accessor. Otherwise

sof 2016/04/11 06:23:32 Move this comment down next to dispose() also?

// its client back reference could end up being unsafely used during

// the lazy sweeping phase.

- EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

MIDIAccess(PassOwnPtr<MIDIAccessor>, bool sysexEnabled, const Vector<MIDIAccessInitializer::PortDescriptor>&, ExecutionContext*);

+ void dispose();

OwnPtr<MIDIAccessor> m_accessor;

bool m_sysexEnabled;