third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 1876703002: Oilpan: Replace EAGERLY_FINALIZE in EventTarget's hierarchy with pre-finalizers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h ('k') | third_party/WebKit/Source/modules/webmidi/MIDIAccess.h » ('j') | third_party/WebKit/Source/modules/webmidi/MIDIAccess.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index f0490d96d5efd72e428b1c0e662cab5ca536fd0e..bd3686aaf2df6d18b0e24f89777e7f2dac2c73a3 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -106,6 +106,7 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(ExecutionContext* execution

{

ASSERT(m_handle);

ASSERT(!m_handle->registration()->proxy());

+ ThreadState::current()->registerPreFinalizer(this);

if (!executionContext)

return;

@@ -118,6 +119,11 @@ ServiceWorkerRegistration::~ServiceWorkerRegistration()

{

}

+void ServiceWorkerRegistration::dispose()

+ m_handle.clear();

DEFINE_TRACE(ServiceWorkerRegistration)

{

visitor->trace(m_installing);