Convert Media Router to use compiled_resources2.gyp.

Convert Media Router to use compiled_resources2.gyp.

BUG=593899
Committed: https://crrev.com/dd6ee19ff0f59064403d4ddf3843de1df1927229
Cr-Commit-Position: refs/heads/master@{#390149}

[apacible, 2016-04-10 03:03:12]

Description was changed from

==========
asdf

BUG=
==========

to

==========
Add Media Router to compiled_resources2.gyp.

BUG=593899
==========

[apacible, 2016-04-21 03:49:12]

Patchset #2 (id:20001) has been deleted

[apacible, 2016-04-21 03:49:15]

Patchset #1 (id:1) has been deleted

[apacible, 2016-04-21 04:04:24]

Description was changed from

==========
Add Media Router to compiled_resources2.gyp.

BUG=593899
==========

to

==========
Convert Media Router to use compiled_resources2.gyp.

BUG=593899
==========

[apacible, 2016-04-21 04:20:00]

Patchset #1 (id:40001) has been deleted

[apacible, 2016-04-21 12:36:29]

apacible@chromium.org changed reviewers:
+ dbeam@chromium.org

[apacible, 2016-04-21 12:43:07]

Hey Dan,

PTAL, thanks!

I started converting the Media Router compiled_resources.gyp to v2. It compiles
without errors without all of the dependencies I'd expect (e.g.
media_router_data for more targets or any of the polymer dependencies). Is this
expected? Feedback appreciated, thanks!

[Dan Beam, 2016-04-21 16:36:58]

https://codereview.chromium.org/1876653002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:36: 'target_name':
'elements/media_router_header/media_router_header',
can you just put a compiled_resources2.gyp in elements/media_router_header/
instead of putting the path in the target_name?

[apacible, 2016-04-25 16:44:07]

https://codereview.chromium.org/1876653002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:36: 'target_name':
'elements/media_router_header/media_router_header',
On 2016/04/21 16:36:57, Dan Beam wrote:
> can you just put a compiled_resources2.gyp in elements/media_router_header/
> instead of putting the path in the target_name?

Done. I also did this for others so the target_name didn't have the path.

[Dan Beam, 2016-04-25 18:24:34]

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:14:
'elements/media_router_header/compiled_resources2.gyp:*',
why *?

[apacible, 2016-04-25 18:29:01]

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:14:
'elements/media_router_header/compiled_resources2.gyp:*',
On 2016/04/25 18:24:34, Dan Beam wrote:
> why *?

There's only one target in that gyp file. Should I specify specific targets
here/elsewhere, even if the file only has a single target?

[Dan Beam, 2016-04-27 02:26:14]

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:14:
'elements/media_router_header/compiled_resources2.gyp:*',
On 2016/04/25 18:29:00, apacible wrote:
> On 2016/04/25 18:24:34, Dan Beam wrote:
> > why *?
> 
> There's only one target in that gyp file. Should I specify specific targets
> here/elsewhere, even if the file only has a single target?

yes

[apacible, 2016-04-27 15:47:41]

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/media_router/compiled_resources2.gyp (right):

https://codereview.chromium.org/1876653002/diff/80001/chrome/browser/resource...
chrome/browser/resources/media_router/compiled_resources2.gyp:14:
'elements/media_router_header/compiled_resources2.gyp:*',
On 2016/04/27 02:26:14, Dan Beam wrote:
> On 2016/04/25 18:29:00, apacible wrote:
> > On 2016/04/25 18:24:34, Dan Beam wrote:
> > > why *?
> > 
> > There's only one target in that gyp file. Should I specify specific targets
> > here/elsewhere, even if the file only has a single target?
> 
> yes

Done.

[Dan Beam, 2016-04-27 19:03:53]

lgtm

[apacible, 2016-04-27 19:31:26]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876653002/100001

[commit-bot: I haz the power, 2016-04-27 19:37:48]

Description was changed from

==========
Convert Media Router to use compiled_resources2.gyp.

BUG=593899
==========

to

==========
Convert Media Router to use compiled_resources2.gyp.

BUG=593899
==========

[commit-bot: I haz the power, 2016-04-27 19:37:49]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:11:56]

Patchset 3 (id:??) landed as
https://crrev.com/dd6ee19ff0f59064403d4ddf3843de1df1927229
Cr-Commit-Position: refs/heads/master@{#390149}

[commit-bot: I haz the power, 2016-04-30 17:51:16]

Description was changed from

==========
Convert Media Router to use compiled_resources2.gyp.

BUG=593899
==========

to

==========
Convert Media Router to use compiled_resources2.gyp.

BUG=593899

Committed: https://crrev.com/dd6ee19ff0f59064403d4ddf3843de1df1927229
Cr-Commit-Position: refs/heads/master@{#390149}
==========