chrome/browser/resources/media_router/compiled_resources2.gyp - Issue 1876653002: Convert Media Router to use compiled_resources2.gyp.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/media_router/compiled_resources2.gyp

Issue 1876653002: Convert Media Router to use compiled_resources2.gyp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per dbeam@'s comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/media_router/compiled_resources.gyp ('k') | chrome/browser/resources/media_router/elements/issue_banner/compiled_resources2.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'targets': [

	6 {

	7 'target_name': 'externs',

	8 'includes': ['../../../../third_party/closure_compiler/include_js.gypi'],

	9 },

	10 {

	11 'target_name': 'media_router',

	12 'dependencies': [

	13 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',

	14 'elements/media_router_header/compiled_resources2.gyp:*',
	Dan Beam 2016/04/25 18:24:34 why ? why ? apacible 2016/04/25 18:29:00 There's only one target in that gyp file. Should I Show quoted text On 2016/04/25 18:24:34, Dan Beam wrote: > why ? There's only one target in that gyp file. Should I specify specific targets here/elsewhere, even if the file only has a single target? Dan Beam* 2016/04/27 02:26:14 yes Show quoted text On 2016/04/25 18:29:00, apacible wrote: > On 2016/04/25 18:24:34, Dan Beam wrote: > > why ? > > There's only one target in that gyp file. Should I specify specific targets > here/elsewhere, even if the file only has a single target? yes apacible* 2016/04/27 15:47:41 Done. Show quoted text On 2016/04/27 02:26:14, Dan Beam wrote: > On 2016/04/25 18:29:00, apacible wrote: > > On 2016/04/25 18:24:34, Dan Beam wrote: > > > why *? > > > > There's only one target in that gyp file. Should I specify specific targets > > here/elsewhere, even if the file only has a single target? > > yes Done.
	15 'elements/media_router_container/compiled_resources2.gyp:*',

	16 ],

	17 'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],

	18 },

	19 {

	20 'target_name': 'media_router_data',

	21 'dependencies': [

	22 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',

	23 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

	24 ],

	25 'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],

	26 },

	27 {

	28 'target_name': 'media_router_ui_interface',

	29 'dependencies': [

	30 'elements/media_router_header/compiled_resources2.gyp:*',

	31 'elements/media_router_container/compiled_resources2.gyp:*',

	32 ],

	33 'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],

	34 },

	35 ],

	36 }

OLD	NEW