Issue 1876603002: use type information to filter RHS of "is" expression for imported types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1876603002: use type information to filter RHS of "is" expression for imported types (Closed)

Created:
4 years, 8 months ago by danrubel

Modified:
4 years, 8 months ago

Reviewers:
jwren

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

use type information to filter RHS of "is" expression for imported types fixes #22357 R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/657f88d7f048e977ff0283b92df9453f6ab0f341

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -13 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart	View	2 chunks	+14 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart	View	5 chunks	+70 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

jwren

On 2016/04/09 15:19:07, danrubel wrote: LGTM Thanks Dan. Are there missing tests local libraries, or ...

4 years, 8 months ago (2016-04-11 16:43:23 UTC) #3

danrubel

4 years, 8 months ago (2016-04-11 19:57:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
657f88d7f048e977ff0283b92df9453f6ab0f341 (presubmit successful).