pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart - Issue 1876603002: use type information to filter RHS of "is" expression for imported types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

Issue 1876603002: use type information to filter RHS of "is" expression for imported types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

index 7f04c6b306d923dc10bfea4d65010eea39c47eb0..68beb6a0a4e51fc26f4b8cee0cd4dcbdc8be9545 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

@@ -44,7 +44,11 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor

@override

void visitClassElement(ClassElement element) {

if (optype.includeTypeNameSuggestions) {

- addSuggestion(element, prefix: prefix, relevance: DART_RELEVANCE_DEFAULT);

+ // if includeTypeNameSuggestions, then use the filter

+ if (optype.typeNameSuggestionsFilter(element.type)) {

+ addSuggestion(element,

+ prefix: prefix, relevance: DART_RELEVANCE_DEFAULT);

+ }

}

if (optype.includeConstructorSuggestions) {

_addConstructorSuggestions(element, DART_RELEVANCE_DEFAULT);