Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 1876413002: Subzero. WASM. Additional progress. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Merging with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringX86BaseImpl.h
diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h
index 0bf03ebf327a6e711dde47bcafe81514bca8d880..745e2b52e46df56d4c6eb6b92cdf296653697195 100644
--- a/src/IceTargetLoweringX86BaseImpl.h
+++ b/src/IceTargetLoweringX86BaseImpl.h
@@ -6096,6 +6096,15 @@ void TargetX86Base<TraitsType>::lowerUnreachable(
}
template <typename TraitsType>
+void TargetX86Base<TraitsType>::lowerBreakpoint(
+ const InstBreakpoint * /*Instr*/) {
+ _int3();
+ // Add a fake use of esp to make sure esp adjustments after the breakpoint do
+ // not get dead-code eliminated.
+ keepEspLiveAtExit();
Jim Stichnoth 2016/04/14 20:03:44 I don't think this should be necessary. Can it be
Eric Holk 2016/04/15 15:24:27 Done. I cargo-culted it from lowerUnreachable, so
+}
+
+template <typename TraitsType>
void TargetX86Base<TraitsType>::lowerRMW(const InstX86FakeRMW *RMW) {
// If the beacon variable's live range does not end in this instruction, then
// it must end in the modified Store instruction that follows. This means

Powered by Google App Engine
This is Rietveld 408576698