Subzero. WASM. Additional progress.

src/IceTargetLoweringX86BaseImpl.h

 //===- subzero/src/IceTargetLoweringX86BaseImpl.h - x86 lowering -*- C++ -*-==//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 6078 matching lines @@
 template <typename TraitsType>
 void TargetX86Base<TraitsType>::lowerUnreachable(
     const InstUnreachable * /*Instr*/) {
   _ud2();
   // Add a fake use of esp to make sure esp adjustments after the unreachable
   // do not get dead-code eliminated.
   keepEspLiveAtExit();
 }
 
 template <typename TraitsType>
+void TargetX86Base<TraitsType>::lowerBreakpoint(
+    const InstBreakpoint * /*Instr*/) {
+  _int3();
+  // Add a fake use of esp to make sure esp adjustments after the breakpoint do
+  // not get dead-code eliminated.
+  keepEspLiveAtExit();

[Jim Stichnoth, 2016/04/14 20:03:44]

I don't think this should be necessary.  Can it be removed?

[Eric Holk, 2016/04/15 15:24:27]

Done.

I cargo-culted it from lowerUnreachable, so I know of no reason why it needs to
be here.

+}
+
+template <typename TraitsType>
 void TargetX86Base<TraitsType>::lowerRMW(const InstX86FakeRMW *RMW) {
   // If the beacon variable's live range does not end in this instruction, then
   // it must end in the modified Store instruction that follows. This means
   // that the original Store instruction is still there, either because the
   // value being stored is used beyond the Store instruction, or because dead
   // code elimination did not happen. In either case, we cancel RMW lowering
   // (and the caller deletes the RMW instruction).
   if (!RMW->isLastUse(RMW->getBeacon()))
     return;
   Operand *Src = RMW->getData();
@@ skipping 1309 matching lines @@
         emitGlobal(*Var, SectionSuffix);
       }
     }
   } break;
   }
 }
 } // end of namespace X86NAMESPACE
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICETARGETLOWERINGX86BASEIMPL_H