third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/v8.gypi » ('j') | third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index 6535932fb074bff77eeaa177d48bfb8dc3a389f6..244269f515cc62d5d042052d3f0de8b6848316dc 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -31,6 +31,7 @@

#include "bindings/core/v8/ScriptCallStack.h"

#include "bindings/core/v8/ScriptController.h"

#include "bindings/core/v8/ScriptValue.h"

+#include "bindings/core/v8/ScriptWrappableHeapTracer.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8DOMException.h"

#include "bindings/core/v8/V8ErrorEvent.h"

@@ -320,6 +321,9 @@ static void initializeV8Common(v8::Isolate* isolate)

{

isolate->AddGCPrologueCallback(V8GCController::gcPrologue);

isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue);

+ if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {

+ isolate->SetEmbedderHeapTracer(new ScriptWrappableHeapTracer());

+ }

v8::Debug::SetLiveEditEnabled(isolate, false);