third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('K') | « third_party/WebKit/Source/bindings/templates/interface_base.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestTraceWrapperReferences.h » ('j') | third_party/WebKit/Source/core/dom/NodeRareData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl

diff --git a/content/test/data/service_worker/fetch_event_respond_with_fetch.js b/third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl

similarity index 58%

copy from content/test/data/service_worker/fetch_event_respond_with_fetch.js

copy to third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl

index df76d0a094fd0d876c78cc9f327df6e213e056c2..e159eab3410a0d9fc66c51dd82253d6dcef59db5 100644

--- a/content/test/data/service_worker/fetch_event_respond_with_fetch.js

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestTraceWrapperReferences.idl

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-this.onfetch = function(event) {

- event.respondWith(fetch(event.request));

+ TraceWrapperReferences=(firstChild,nextSibling,prevSibling,parent)

haraken 2016/04/18 04:35:42 Nit: Can you add [TraceWrapperReferences] to some

Marcel Hlopko 2016/04/18 11:45:35 Done.

+] interface TestTraceWrapperReferences : Node {

};