third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h ('K') | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h » ('j') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

index 62ee227650a36c24720f7bb4e9295a1c5cb1f41d..0274315ece458cf2ac7991bba31d19576a7160d6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

@@ -137,6 +137,15 @@ void DOMWrapperWorld::allWorldsInMainThread(Vector<RefPtr<DOMWrapperWorld>>& wor

worlds.append(it->value);

}

+void DOMWrapperWorld::visitAllWorldsInMainThread(DOMWrapperWorldVisitor& visitor)

+ ASSERT(isMainThread());

+ visitor.visit(mainWorld());

+ WorldMap& isolatedWorlds = isolatedWorldMap();

+ for (WorldMap::iterator it = isolatedWorlds.begin(); it != isolatedWorlds.end(); ++it)

+ visitor.visit(*(it->value));

DOMWrapperWorld::~DOMWrapperWorld()

{

ASSERT(!isMainWorld());