Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp
index 3534a4ebfb5d2b1cd83854203e91f08945483b90..7c1d7a4e05102f475634b18fbe4c4068799bc8f5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp
@@ -5,6 +5,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/DOMDataStore.h"
+#include "bindings/core/v8/ScriptWrappableHeapTracer.h"
#include "bindings/core/v8/V8DOMWrapper.h"
namespace blink {
@@ -35,4 +36,9 @@ v8::Local<v8::Object> ScriptWrappable::associateWithWrapper(v8::Isolate* isolate
return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperTypeInfo, wrapper);
}
+void ScriptWrappable::markWrapper(v8::Isolate* isolate) const
haraken 2016/04/18 04:35:41 This method looks redundant. The caller sites of t
Marcel Hlopko 2016/04/18 11:45:35 I agree, in this form the method is useless. I cha
+{
+ ScriptWrappableHeapTracer::markWrapper(this, isolate);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698