base/task_scheduler/scheduler_thread_pool_impl_unittest.cc - Issue 1876363004: TaskScheduler [11] Support ExecutionMode::SINGLE_THREADED.

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

Issue 1876363004: TaskScheduler [11] Support ExecutionMode::SINGLE_THREADED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@8_delayed

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/task_scheduler/scheduler_thread_pool_impl.cc ('K') | « base/task_scheduler/scheduler_thread_pool_impl.cc ('k') | base/task_scheduler/scheduler_worker_thread.h » ('j') | base/task_scheduler/scheduler_worker_thread_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

diff --git a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

index 691d0dde959cad136b4220ba8333b31f52b09f18..72a280d9fb2a1a32f20368e9ab797b053008f982 100644

--- a/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

+++ b/base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

@@ -26,6 +26,7 @@

#include "base/task_scheduler/test_task_factory.h"

#include "base/threading/platform_thread.h"

#include "base/threading/simple_thread.h"

+#include "base/threading/thread_checker_impl.h"

gab 2016/04/25 21:00:20 Unused?

fdoray 2016/04/25 22:34:44 Done.

#include "testing/gtest/include/gtest/gtest.h"

namespace base {

@@ -314,6 +315,9 @@ INSTANTIATE_TEST_CASE_P(Parallel,

INSTANTIATE_TEST_CASE_P(Sequenced,

TaskSchedulerThreadPoolImplTest,

::testing::Values(ExecutionMode::SEQUENCED));

+INSTANTIATE_TEST_CASE_P(SingleThreaded,

+ TaskSchedulerThreadPoolImplTest,

+ ::testing::Values(ExecutionMode::SINGLE_THREADED));

gab 2016/04/25 21:00:20 Seeing no other modification then this to this tes

fdoray 2016/04/25 22:34:44 TestTaskFactory verifies that all tasks run on the

gab 2016/04/26 11:46:27 Ah I had missed that the extracted TestTaskFactory

} // namespace internal

} // namespace base