TaskScheduler [11] Support ExecutionMode::SINGLE_THREADED.

base/task_scheduler/scheduler_thread_pool_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/scheduler_thread_pool_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <unordered_set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/synchronization/condition_variable.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/task_runner.h"
 #include "base/task_scheduler/delayed_task_manager.h"
 #include "base/task_scheduler/sequence.h"
 #include "base/task_scheduler/sequence_sort_key.h"
 #include "base/task_scheduler/task_tracker.h"
 #include "base/task_scheduler/test_task_factory.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/simple_thread.h"
+#include "base/threading/thread_checker_impl.h"

[gab, 2016/04/25 21:00:20]

Unused?

[fdoray, 2016/04/25 22:34:44]

Done.

 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace internal {
 namespace {
 
 const size_t kNumThreadsInThreadPool = 4;
 const size_t kNumThreadsPostingTasks = 4;
 const size_t kNumTasksPostedPerThread = 150;
 
@@ skipping 268 matching lines @@
   // The task should run.
   task_ran.Wait();
 }
 
 INSTANTIATE_TEST_CASE_P(Parallel,
                         TaskSchedulerThreadPoolImplTest,
                         ::testing::Values(ExecutionMode::PARALLEL));
 INSTANTIATE_TEST_CASE_P(Sequenced,
                         TaskSchedulerThreadPoolImplTest,
                         ::testing::Values(ExecutionMode::SEQUENCED));
+INSTANTIATE_TEST_CASE_P(SingleThreaded,
+                        TaskSchedulerThreadPoolImplTest,
+                        ::testing::Values(ExecutionMode::SINGLE_THREADED));

[gab, 2016/04/25 21:00:20]

Seeing no other modification then this to this test (i.e. no if (GetParam() ==
SINGLE_THREADED) tells me we're not really testing the single-threaded stuff,
i.e. the impl could return a SEQUENCED task runner and this test would be
happy.. can we come up with a test that covers the underlying impl further?

[fdoray, 2016/04/25 22:34:44]

TestTaskFactory verifies that all tasks run on the same thread when it is
instantiated with SINGLE_THREADED.

API:
https://codereview.chromium.org/1911493002/diff/80001/base/task_scheduler/tes...
Code:
https://codereview.chromium.org/1911493002/diff/80001/base/task_scheduler/tes...

[gab, 2016/04/26 11:46:27]

Ah I had missed that the extracted TestTaskFactory already had logic for
SINGLE_THREADED and was surprised not to see some in this CL, all good then :-)!

 
 }  // namespace internal
 }  // namespace base