fpdfsdk/javascript/global.h - Issue 1876203002: Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/global.h

Issue 1876203002: Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Pass by const ref Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/global.h

diff --git a/fpdfsdk/javascript/global.h b/fpdfsdk/javascript/global.h

index 335b540271641e08b95c6ea029d2dfd04897c965..02c51d98a934f56e61bd7dfc5a7db2732856d266 100644

--- a/fpdfsdk/javascript/global.h

+++ b/fpdfsdk/javascript/global.h

@@ -59,7 +59,7 @@ class JSGlobalAlternate : public CJS_EmbedObj {

void UpdateGlobalPersistentVariables();

void CommitGlobalPersisitentVariables(IJS_Context* cc);

void DestroyGlobalPersisitentVariables();

- FX_BOOL SetGlobalVariables(const FX_CHAR* propname,

+ FX_BOOL SetGlobalVariables(const CFX_ByteString& propname,

int nType,

double dData,

bool bData,

« no previous file with comments | « fpdfsdk/javascript/JS_GlobalData.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »