Remove ICodec_* Interfaces.

Remove ICodec_* Interfaces.

All of the ICodec_* interfaces had a single implementation. This CL removes
the interfaces and uses the concrete classes in their place.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/d55e11eeb8ebf1e226a1166f395ba77248ce84c3

[dsinclair, 2016-04-11 16:23:19]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-11 16:23:19]

PTAL.

[Tom Sepez, 2016-04-11 17:16:21]

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
File core/fpdfapi/fpdf_basic_module.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
core/fpdfapi/fpdf_basic_module.cpp:48: return m_pCodecModule ?
m_pCodecModule->GetFaxModule() : NULL;
nits: nullptrs.

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:871: R = G = B = 0.0f;
nit: one per line.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
File core/fxcodec/codec/ccodec_gifmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
core/fxcodec/codec/ccodec_gifmodule.h:14: CCodec_GifModule() {
FXSYS_memset(m_szLastError, '\0', 256); }
howzabout just 0 and sizeof(m_szLastError) for consistency with the other place
we do the exact same thing?

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
File core/fxcodec/codec/ccodec_pngmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
core/fxcodec/codec/ccodec_pngmodule.h:17: CCodec_PngModule() {
FXSYS_memset(m_szLastError, '\0', PNG_ERROR_SIZE); }
Note:  In all of these, its probably sufficient to just set m_szLastError[0] =
0;

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
File core/fxcodec/codec/ccodec_scanlinedecoder.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
core/fxcodec/codec/ccodec_scanlinedecoder.h:30: virtual FX_BOOL v_Rewind() = 0;
Do these still need to be virtual?

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
File core/fxcodec/codec/ccodec_tiffmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
core/fxcodec/codec/ccodec_tiffmodule.h:22: void GetFrames(void* ctx, int32_t&
frames);
srsly, what's a ctx really in this context?

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec.cpp:407: CCodec_RLScanlineDecoder*
pRLScanlineDecoder = new CCodec_RLScanlineDecoder;
unique_ptr.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec.cpp:413: return pRLScanlineDecoder;
return blah.release();

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec_progress.cpp:14: #define FXCODEC_BLOCK_SIZE 4096
namespaces don't affect #defines, and would be empty otherwise.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
File core/fxcodec/codec/include/ccodec_progressivedecoder.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
core/fxcodec/codec/include/ccodec_progressivedecoder.h:11: #include
"core/fxcodec/include/fx_codec_def.h"
alphabetize

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
File core/fxcodec/include/fx_codec.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
core/fxcodec/include/fx_codec.h:18: #include
"core/fxcodec/codec/ccodec_faxmodule.h"
alphabetize, check the others, too

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
File core/fxge/dib/fx_dib_composite.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:3968: void* icc_module,
can these not be void*'s maybe?

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:3970: CCodec_IccModule* pIccModule =
static_cast<CCodec_IccModule*>(icc_module);
with the hope of avoiding the cast here.

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:4033: CCodec_IccModule* pIccModule =
static_cast<CCodec_IccModule*>(icc_module);
same

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
File xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:24: #include
"core/fxcodec/codec/include/ccodec_progressivedecoder.h"
alpha

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:35: CCodec_ModuleMgr*
pCodecMgr = NULL;
nit: nullptrs.

[dsinclair, 2016-04-11 20:40:40]

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
File core/fpdfapi/fpdf_basic_module.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
core/fpdfapi/fpdf_basic_module.cpp:48: return m_pCodecModule ?
m_pCodecModule->GetFaxModule() : NULL;
On 2016/04/11 17:16:20, Tom Sepez wrote:
> nits: nullptrs.

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:871: R = G = B = 0.0f;
On 2016/04/11 17:16:21, Tom Sepez wrote:
> nit: one per line.

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
File core/fxcodec/codec/ccodec_gifmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
core/fxcodec/codec/ccodec_gifmodule.h:14: CCodec_GifModule() {
FXSYS_memset(m_szLastError, '\0', 256); }
On 2016/04/11 17:16:21, Tom Sepez wrote:
> howzabout just 0 and sizeof(m_szLastError) for consistency with the other
place
> we do the exact same thing?

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
File core/fxcodec/codec/ccodec_pngmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
core/fxcodec/codec/ccodec_pngmodule.h:17: CCodec_PngModule() {
FXSYS_memset(m_szLastError, '\0', PNG_ERROR_SIZE); }
On 2016/04/11 17:16:21, Tom Sepez wrote:
> Note:  In all of these, its probably sufficient to just set m_szLastError[0] =
> 0;


Looking at the usage, I don't think it's guaranteed to write a \0 at the end of
the string.

FXSYS_strncpy((char*)bmp_ptr->err_ptr, err_msg, BMP_MAX_ERROR_SIZE - 1);

(Where err_ptr is m_szLastError).

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
File core/fxcodec/codec/ccodec_scanlinedecoder.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
core/fxcodec/codec/ccodec_scanlinedecoder.h:30: virtual FX_BOOL v_Rewind() = 0;
On 2016/04/11 17:16:21, Tom Sepez wrote:
> Do these still need to be virtual?

Yes, there are subclasses of CCodec_ScanlineDecoder which implement these
methods.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
File core/fxcodec/codec/ccodec_tiffmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
core/fxcodec/codec/ccodec_tiffmodule.h:22: void GetFrames(void* ctx, int32_t&
frames);
On 2016/04/11 17:16:21, Tom Sepez wrote:
> srsly, what's a ctx really in this context?

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec.cpp:407: CCodec_RLScanlineDecoder*
pRLScanlineDecoder = new CCodec_RLScanlineDecoder;
On 2016/04/11 17:16:21, Tom Sepez wrote:
> unique_ptr.

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec.cpp:413: return pRLScanlineDecoder;
On 2016/04/11 17:16:21, Tom Sepez wrote:
> return blah.release();

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec_progress.cpp:14: #define FXCODEC_BLOCK_SIZE 4096
On 2016/04/11 17:16:21, Tom Sepez wrote:
> namespaces don't affect #defines, and would be empty otherwise.

Yea, I'd moved stuff in here, then had to move it out to the header.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
File core/fxcodec/codec/include/ccodec_progressivedecoder.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
core/fxcodec/codec/include/ccodec_progressivedecoder.h:11: #include
"core/fxcodec/include/fx_codec_def.h"
On 2016/04/11 17:16:21, Tom Sepez wrote:
> alphabetize

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
File core/fxcodec/include/fx_codec.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
core/fxcodec/include/fx_codec.h:18: #include
"core/fxcodec/codec/ccodec_faxmodule.h"
On 2016/04/11 17:16:21, Tom Sepez wrote:
> alphabetize, check the others, too

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
File core/fxge/dib/fx_dib_composite.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:3968: void* icc_module,
On 2016/04/11 17:16:21, Tom Sepez wrote:
> can these not be void*'s maybe?

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:3970: CCodec_IccModule* pIccModule =
static_cast<CCodec_IccModule*>(icc_module);
On 2016/04/11 17:16:21, Tom Sepez wrote:
> with the hope of avoiding the cast here.

Done.

https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
core/fxge/dib/fx_dib_composite.cpp:4033: CCodec_IccModule* pIccModule =
static_cast<CCodec_IccModule*>(icc_module);
On 2016/04/11 17:16:21, Tom Sepez wrote:
> same

Done.

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
File xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp (right):

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:24: #include
"core/fxcodec/codec/include/ccodec_progressivedecoder.h"
On 2016/04/11 17:16:21, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:35: CCodec_ModuleMgr*
pCodecMgr = NULL;
On 2016/04/11 17:16:21, Tom Sepez wrote:
> nit: nullptrs.

Done.

[dsinclair, 2016-04-12 13:02:34]

On 2016/04/11 20:40:40, dsinclair wrote:
>
https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
> File core/fpdfapi/fpdf_basic_module.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_basic_mod...
> core/fpdfapi/fpdf_basic_module.cpp:48: return m_pCodecModule ?
> m_pCodecModule->GetFaxModule() : NULL;
> On 2016/04/11 17:16:20, Tom Sepez wrote:
> > nits: nullptrs.
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
> File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fpdfapi/fpdf_page/cpdf...
> core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:871: R = G = B = 0.0f;
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > nit: one per line.
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
> File core/fxcodec/codec/ccodec_gifmodule.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_g...
> core/fxcodec/codec/ccodec_gifmodule.h:14: CCodec_GifModule() {
> FXSYS_memset(m_szLastError, '\0', 256); }
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > howzabout just 0 and sizeof(m_szLastError) for consistency with the other
> place
> > we do the exact same thing?
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
> File core/fxcodec/codec/ccodec_pngmodule.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
> core/fxcodec/codec/ccodec_pngmodule.h:17: CCodec_PngModule() {
> FXSYS_memset(m_szLastError, '\0', PNG_ERROR_SIZE); }
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > Note:  In all of these, its probably sufficient to just set m_szLastError[0]
=
> > 0;
> 
> 
> Looking at the usage, I don't think it's guaranteed to write a \0 at the end
of
> the string.
> 
> FXSYS_strncpy((char*)bmp_ptr->err_ptr, err_msg, BMP_MAX_ERROR_SIZE - 1);
> 
> (Where err_ptr is m_szLastError).
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
> File core/fxcodec/codec/ccodec_scanlinedecoder.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_s...
> core/fxcodec/codec/ccodec_scanlinedecoder.h:30: virtual FX_BOOL v_Rewind() =
0;
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > Do these still need to be virtual?
> 
> Yes, there are subclasses of CCodec_ScanlineDecoder which implement these
> methods.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
> File core/fxcodec/codec/ccodec_tiffmodule.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_t...
> core/fxcodec/codec/ccodec_tiffmodule.h:22: void GetFrames(void* ctx, int32_t&
> frames);
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > srsly, what's a ctx really in this context?
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
> File core/fxcodec/codec/fx_codec.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
> core/fxcodec/codec/fx_codec.cpp:407: CCodec_RLScanlineDecoder*
> pRLScanlineDecoder = new CCodec_RLScanlineDecoder;
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > unique_ptr.
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
> core/fxcodec/codec/fx_codec.cpp:413: return pRLScanlineDecoder;
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > return blah.release();
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
> File core/fxcodec/codec/fx_codec_progress.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/fx_codec...
> core/fxcodec/codec/fx_codec_progress.cpp:14: #define FXCODEC_BLOCK_SIZE 4096
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > namespaces don't affect #defines, and would be empty otherwise.
> 
> Yea, I'd moved stuff in here, then had to move it out to the header.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
> File core/fxcodec/codec/include/ccodec_progressivedecoder.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/include/...
> core/fxcodec/codec/include/ccodec_progressivedecoder.h:11: #include
> "core/fxcodec/include/fx_codec_def.h"
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > alphabetize
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
> File core/fxcodec/include/fx_codec.h (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/include/fx_cod...
> core/fxcodec/include/fx_codec.h:18: #include
> "core/fxcodec/codec/ccodec_faxmodule.h"
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > alphabetize, check the others, too
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
> File core/fxge/dib/fx_dib_composite.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
> core/fxge/dib/fx_dib_composite.cpp:3968: void* icc_module,
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > can these not be void*'s maybe?
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
> core/fxge/dib/fx_dib_composite.cpp:3970: CCodec_IccModule* pIccModule =
> static_cast<CCodec_IccModule*>(icc_module);
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > with the hope of avoiding the cast here.
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/core/fxge/dib/fx_dib_compos...
> core/fxge/dib/fx_dib_composite.cpp:4033: CCodec_IccModule* pIccModule =
> static_cast<CCodec_IccModule*>(icc_module);
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > same
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
> File xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp (right):
> 
>
https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
> xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:24: #include
> "core/fxcodec/codec/include/ccodec_progressivedecoder.h"
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > alpha
> 
> Done.
> 
>
https://codereview.chromium.org/1876023003/diff/1/xfa/fxbarcode/BC_BufferedIm...
> xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp:35: CCodec_ModuleMgr*
> pCodecMgr = NULL;
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > nit: nullptrs.
> 
> Done.


Ping.

[Tom Sepez, 2016-04-12 16:58:56]

lgtm

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
File core/fxcodec/codec/ccodec_pngmodule.h (right):

https://codereview.chromium.org/1876023003/diff/1/core/fxcodec/codec/ccodec_p...
core/fxcodec/codec/ccodec_pngmodule.h:17: CCodec_PngModule() {
FXSYS_memset(m_szLastError, '\0', PNG_ERROR_SIZE); }
On 2016/04/11 20:40:39, dsinclair wrote:
> On 2016/04/11 17:16:21, Tom Sepez wrote:
> > Note:  In all of these, its probably sufficient to just set m_szLastError[0]
=
> > 0;
> 
> 
> Looking at the usage, I don't think it's guaranteed to write a \0 at the end
of
> the string.
> 
> FXSYS_strncpy((char*)bmp_ptr->err_ptr, err_msg, BMP_MAX_ERROR_SIZE - 1);
> 
> (Where err_ptr is m_szLastError).
Ok, I'd be happier if the strncpy's were always followed by a null byte
assignment, that way its easier to audit for correctness ...

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_bmp.cpp (right):

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_bmp.cpp:47: FXBMP_Context* p =
(FXBMP_Context*)FX_Alloc(uint8_t, sizeof(FXBMP_Context));
nit: this could be just
FXBMP_Context* p = FX_Alloc(FXBMP_Context, 1);
and lose the cast.

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_gif.cpp (right):

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_gif.cpp:74: FXGIF_Context* p =
(FXGIF_Context*)FX_Alloc(uint8_t, sizeof(FXGIF_Context));
nit: same here.

[dsinclair, 2016-04-12 17:47:55]

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_bmp.cpp (right):

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_bmp.cpp:47: FXBMP_Context* p =
(FXBMP_Context*)FX_Alloc(uint8_t, sizeof(FXBMP_Context));
On 2016/04/12 16:58:55, Tom Sepez wrote:
> nit: this could be just
> FXBMP_Context* p = FX_Alloc(FXBMP_Context, 1);
> and lose the cast.

Done.

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_gif.cpp (right):

https://codereview.chromium.org/1876023003/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_gif.cpp:74: FXGIF_Context* p =
(FXGIF_Context*)FX_Alloc(uint8_t, sizeof(FXGIF_Context));
On 2016/04/12 16:58:56, Tom Sepez wrote:
> nit: same here.

Done.

[dsinclair, 2016-04-12 17:48:34]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-12 17:48:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1876023003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 17:48:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876023003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876023003/40001

[commit-bot: I haz the power, 2016-04-12 18:21:25]

Description was changed from

==========
Remove ICodec_* Interfaces.

All of the ICodec_* interfaces had a single implementation. This CL removes
the interfaces and uses the concrete classes in their place.

BUG=pdfium:468
==========

to

==========
Remove ICodec_* Interfaces.

All of the ICodec_* interfaces had a single implementation. This CL removes
the interfaces and uses the concrete classes in their place.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/d55e11eeb8ebf1e226a1166f395ba77248ce...
==========

[commit-bot: I haz the power, 2016-04-12 18:21:26]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/d55e11eeb8ebf1e226a1166f395ba77248ce...