Remove ICodec_* Interfaces.

core/fxcodec/codec/ccodec_pngmodule.h

+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+
+#ifndef CORE_FXCODEC_CODEC_CCODEC_PNGMODULE_H_
+#define CORE_FXCODEC_CODEC_CCODEC_PNGMODULE_H_
+
+#include "core/fxcrt/include/fx_system.h"
+
+class CFX_DIBAttribute;
+
+#define PNG_ERROR_SIZE 256
+class CCodec_PngModule {
+ public:
+  CCodec_PngModule() { FXSYS_memset(m_szLastError, '\0', PNG_ERROR_SIZE); }

[Tom Sepez, 2016/04/11 17:16:21]

Note:  In all of these, its probably sufficient to just set m_szLastError[0] =
0;

[dsinclair, 2016/04/11 20:40:39]

Looking at the usage, I don't think it's guaranteed to write a \0 at the end of
the string.

FXSYS_strncpy((char*)bmp_ptr->err_ptr, err_msg, BMP_MAX_ERROR_SIZE - 1);

(Where err_ptr is m_szLastError).

[Tom Sepez, 2016/04/12 16:58:55]

Ok, I'd be happier if the strncpy's were always followed by a null byte
assignment, that way its easier to audit for correctness ...

+
+  void* Start(void* pModule);
+  void Finish(void* pContext);
+  FX_BOOL Input(void* pContext,
+                const uint8_t* src_buf,
+                uint32_t src_size,
+                CFX_DIBAttribute* pAttribute);
+
+  FX_BOOL (*ReadHeaderCallback)(void* pModule,
+                                int width,
+                                int height,
+                                int bpc,
+                                int pass,
+                                int* color_type,
+                                double* gamma);
+  FX_BOOL (*AskScanlineBufCallback)(void* pModule, int line, uint8_t*& src_buf);
+  void (*FillScanlineBufCompletedCallback)(void* pModule, int pass, int line);
+
+ protected:
+  FX_CHAR m_szLastError[PNG_ERROR_SIZE];
+};
+
+#endif  // CORE_FXCODEC_CODEC_CCODEC_PNGMODULE_H_