Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1875853002: DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages The patch fixes the stick-to-bottom behavior of console in case of multiline messages. The patch does two things: 1. ViewportControl starts to cache provider's itemCount in invalidate call. This ensures that the regular scrolling of viewport is not affected by provider's item changes unless an invalidate method was called. 2. Stick to bottom only in case of non-user-generated gestures. This is done via transitioning to the event.isTrusted flag. BUG=594339 R=dgozman, pfeldman Review URL: https://codereview.chromium.org/1863313002 Cr-Commit-Position: refs/heads/master@{#385872} (cherry picked from commit 1d413c3ebced31d7182b31ff6efb458c5a12216e) Committed: https://chromium.googlesource.com/chromium/src/+/7c8faba3e1586366ae97bba310f0aa6df9b14281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -326 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt View 1 chunk +596 lines, -298 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 11 chunks +25 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
4 years, 8 months ago (2016-04-09 00:11:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c8faba3e1586366ae97bba310f0aa6df9b14281.

Powered by Google App Engine
This is Rietveld 408576698