Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1875733003: Disable string externalization by default. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-08 16:43:56 UTC) #2
Florian Schneider
lgtm
4 years, 8 months ago (2016-04-08 17:19:14 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-08 17:56:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
260ea83950a79f99d4e135ef75c9b314d2ff4b98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698