runtime/vm/dart_api_impl.cc - Issue 1875733003: Disable string externalization by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1875733003: Disable string externalization by default. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index b90abb56926682864a20317f58c791320fcadfe6..a53b4d41d3e384712edba10f699772a4c6ba63f3 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -59,7 +59,7 @@ DEFINE_FLAG(bool, check_function_fingerprints, true,

#endif // defined(DART_NO_SNAPSHOT).

DEFINE_FLAG(bool, verify_acquired_data, false,

"Verify correct API acquire/release of typed data.");

-DEFINE_FLAG(bool, support_externalizable_strings, true,

+DEFINE_FLAG(bool, support_externalizable_strings, false,

"Support Dart_MakeExternalString.");

« no previous file with comments | « no previous file | no next file » | no next file with comments »