Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: media/base/video_frame_pool.cc

Issue 187573006: Allow wrapping a media::VideoFrame with a new view_rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_frame_pool.cc
diff --git a/media/base/video_frame_pool.cc b/media/base/video_frame_pool.cc
index 3ee7c1ad0394eb0d623c59ab684f81f9760874f2..ab5e0e077342928c237cc6b2bdab712d08007982 100644
--- a/media/base/video_frame_pool.cc
+++ b/media/base/video_frame_pool.cc
@@ -72,7 +72,6 @@ scoped_refptr<VideoFrame> VideoFramePool::PoolImpl::CreateFrame(
if (pool_frame->format() == format &&
pool_frame->coded_size() == coded_size &&
- pool_frame->visible_rect() == visible_rect &&
pool_frame->natural_size() == natural_size) {
Ami GONE FROM CHROMIUM 2014/03/05 16:23:42 Should add a subrect test.
perkj_chrome 2014/03/05 16:39:49 ? VideoFramePoolUnitTest::FrameReuseWithDifferentV
frame = pool_frame;
frame->SetTimestamp(timestamp);
@@ -86,7 +85,8 @@ scoped_refptr<VideoFrame> VideoFramePool::PoolImpl::CreateFrame(
}
return VideoFrame::WrapVideoFrame(
- frame, base::Bind(&VideoFramePool::PoolImpl::FrameReleased, this, frame));
+ frame, visible_rect,
+ base::Bind(&VideoFramePool::PoolImpl::FrameReleased, this, frame));
}
void VideoFramePool::PoolImpl::Shutdown() {

Powered by Google App Engine
This is Rietveld 408576698