Allow wrapping a media::VideoFrame with a new view_rect.

media/base/video_frame_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/video_frame_pool.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
@@ skipping 54 matching lines @@
   DCHECK(!is_shutdown_);
 
   scoped_refptr<VideoFrame> frame;
 
   while (!frame && !frames_.empty()) {
       scoped_refptr<VideoFrame> pool_frame = frames_.front();
       frames_.pop_front();
 
       if (pool_frame->format() == format &&
           pool_frame->coded_size() == coded_size &&
-          pool_frame->visible_rect() == visible_rect &&
           pool_frame->natural_size() == natural_size) {

[Ami GONE FROM CHROMIUM, 2014/03/05 16:23:42]

Should add a subrect test.

[perkj_chrome, 2014/03/05 16:39:49]

? VideoFramePoolUnitTest::FrameReuseWithDifferentVisibleRect or did I
missunderstand? 

         frame = pool_frame;
         frame->SetTimestamp(timestamp);
         break;
       }
   }
 
   if (!frame) {
     frame = VideoFrame::CreateFrame(
         format, coded_size, visible_rect, natural_size, timestamp);
   }
 
   return VideoFrame::WrapVideoFrame(
-      frame, base::Bind(&VideoFramePool::PoolImpl::FrameReleased, this, frame));
+      frame, visible_rect,
+      base::Bind(&VideoFramePool::PoolImpl::FrameReleased, this, frame));
 }
 
 void VideoFramePool::PoolImpl::Shutdown() {
   base::AutoLock auto_lock(lock_);
   is_shutdown_ = true;
   frames_.clear();
 }
 
 void VideoFramePool::PoolImpl::FrameReleased(
     const scoped_refptr<VideoFrame>& frame) {
@@ skipping 19 matching lines @@
     base::TimeDelta timestamp) {
   return pool_->CreateFrame(format, coded_size, visible_rect, natural_size,
                             timestamp);
 }
 
 size_t VideoFramePool::GetPoolSizeForTesting() const {
   return pool_->GetPoolSizeForTesting();
 }
 
 }  // namespace media