Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1875683002: Revert of Migrate FastCloneShallowObjectStub to TurboFan (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Migrate FastCloneShallowObjectStub to TurboFan (patchset #7 id:140001 of https://codereview.chromium.org/1838283003/ ) Reason for revert: Makes some WebGL tests flaky: https://codereview.chromium.org/1866373002/ Bisection on tryserver shows this as the culprit. Local repro unfortunately does not work. Original issue's description: > Migrate FastCloneShallowObjectStub to TurboFan > > BUG= > > Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924 > Cr-Commit-Position: refs/heads/master@{#35330} TBR=bmeurer@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/47cce8d6ed86b32dfe92ee65fe81f715f1ac628c Cr-Commit-Position: refs/heads/master@{#35353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -118 lines) Patch
M src/code-stubs.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +8 lines, -76 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 3 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Hablich
Created Revert of Migrate FastCloneShallowObjectStub to TurboFan
4 years, 8 months ago (2016-04-08 11:01:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875683002/1
4 years, 8 months ago (2016-04-08 11:01:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875683002/1
4 years, 8 months ago (2016-04-08 11:02:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/15939) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 11:03:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875683002/1
4 years, 8 months ago (2016-04-08 11:27:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 11:50:52 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47cce8d6ed86b32dfe92ee65fe81f715f1ac628c Cr-Commit-Position: refs/heads/master@{#35353}
4 years, 8 months ago (2016-04-08 11:52:50 UTC) #11
Michael Achenbach
4 years, 8 months ago (2016-04-08 11:58:30 UTC) #12
Message was sent while issue was closed.
FYI: Here is the bisection on the trybots:
https://codereview.chromium.org/1873703002

Powered by Google App Engine
This is Rietveld 408576698