Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1875613004:
Remove stray references to crash_service. (Closed)
|
Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 8 months ago Reviewers:
Dirk Pranke, brucedawson, gab, scottmg, robertshield, Michael Moss, kerz_chromium, grt (UTC plus 2) CC:
chromium-reviews, telemetry-reviews_chromium.org, charliea (OOO until 10-5), agable, nednguyen, sullivan, ajuma Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove stray references to crash_service.
Stop bundling it in the installer (FILES.cfg). Remove the references
to the crash_service target from the perf builders' targets. (Issue
601762)
It's necessary to proceed with the removal of the start_crash_service
step on the bots, because putting it back now breaks the GPU bots
(Issue 601839).
The BUILD.gn removals are proactive, and not actually used yet.
BUG=601762, 601839
Committed: https://crrev.com/4cc1754d4ddb33f39dd9fe9cc9518f78bd840091
Cr-Commit-Position: refs/heads/master@{#386239}
Patch Set 1 #
Messages
Total messages: 27 (10 generated)
kbr@chromium.org changed reviewers: + dpranke@chromium.org
Dirk: please review. Thanks.
Description was changed from ========== Remove stray references to crash_service. The references in FILES.cfg were breaking the chromium.perf Win builders. Also removed the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ========== to ========== Remove stray references to crash_service. The references in FILES.cfg may be breaking the chromium.perf Win builders. Also removed the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ==========
dpranke@chromium.org changed reviewers: + scottmg@chromium.org
lgtm. Scott, do you agree?
I don't think the packaging is what's making the link fail? It looked like crash_service was still running so it couldn't be linked?
On 2016/04/08 19:17:57, scottmg wrote: > I don't think the packaging is what's making the link fail? It looked like > crash_service was still running so it couldn't be linked? Oh, I guess if that's all the things that build it, that might make the bots work for now though. OK, lgtm.
On 2016/04/08 19:18:39, scottmg wrote: > On 2016/04/08 19:17:57, scottmg wrote: > > I don't think the packaging is what's making the link fail? It looked like > > crash_service was still running so it couldn't be linked? > > Oh, I guess if that's all the things that build it, that might make the bots > work for now though. OK, lgtm. Right, this is not the cause of the compile failure (I don't think), but we should still land this CL to remove references to crash_service that aren't needed, before we land your CL and delete crash_service itself.
We should update the CL description to be more accurate, then.
Description was changed from ========== Remove stray references to crash_service. The references in FILES.cfg may be breaking the chromium.perf Win builders. Also removed the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ========== to ========== Remove stray references to crash_service. Stop bundling it in the installer (FILES.cfg). Remove the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ==========
On 2016/04/08 19:23:27, Dirk Pranke wrote: > We should update the CL description to be more accurate, then. Updated the CL description. Please re-review it. Thanks. P.S. Dirk's https://codereview.chromium.org/1873903002 is essential. However removing the crash_service dependency from the chromium_perf_builder target would also fix the build problem since the Perf bots then wouldn't try to rebuild the executable that was still running.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875613004/1
lgtm also.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kerz, mmoss, gab, grt, robertshield, brucedawson: OWNERS review of FILES.cfg please.
lgtm
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875613004/1
Message was sent while issue was closed.
Description was changed from ========== Remove stray references to crash_service. Stop bundling it in the installer (FILES.cfg). Remove the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ========== to ========== Remove stray references to crash_service. Stop bundling it in the installer (FILES.cfg). Remove the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove stray references to crash_service. Stop bundling it in the installer (FILES.cfg). Remove the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 ========== to ========== Remove stray references to crash_service. Stop bundling it in the installer (FILES.cfg). Remove the references to the crash_service target from the perf builders' targets. (Issue 601762) It's necessary to proceed with the removal of the start_crash_service step on the bots, because putting it back now breaks the GPU bots (Issue 601839). The BUILD.gn removals are proactive, and not actually used yet. BUG=601762, 601839 Committed: https://crrev.com/4cc1754d4ddb33f39dd9fe9cc9518f78bd840091 Cr-Commit-Position: refs/heads/master@{#386239} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4cc1754d4ddb33f39dd9fe9cc9518f78bd840091 Cr-Commit-Position: refs/heads/master@{#386239}
Message was sent while issue was closed.
On 2016/04/08 22:44:30, Ken Russell OOO till 4-13-2016 wrote: > kerz, mmoss, gab, grt, robertshield, brucedawson: OWNERS review of FILES.cfg > please. Please don't mass add all OWNERS, this adds overhead to everyone's workflow who has to figure out that there role has already been filled. If it's urgent ping until you find an available reviewer but don't mass email. Thanks, Gab |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
