Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: BUILD.gn

Issue 1875613004: Remove stray references to crash_service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 deps += [ "//chrome:linux_symbols" ] 866 deps += [ "//chrome:linux_symbols" ]
867 } 867 }
868 868
869 if (!is_chromeos) { 869 if (!is_chromeos) {
870 deps += [ "//tools/perf/clear_system_cache" ] 870 deps += [ "//tools/perf/clear_system_cache" ]
871 } 871 }
872 } 872 }
873 873
874 if (is_win) { 874 if (is_win) {
875 deps += [ 875 deps += [
876 "//chrome/tools/crash_service",
877 # "//gpu:angle_perftests", TODO(GYP): crbug.com/537008 876 # "//gpu:angle_perftests", TODO(GYP): crbug.com/537008
878 ] 877 ]
879
880 if (target_cpu == "x86") {
881 deps += [ "//chrome/tools/crash_service:crash_service_win64" ]
882 }
883 } else { 878 } else {
884 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] 879 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
885 } 880 }
886 } 881 }
887 } 882 }
888 883
889 # Because of the source assignment filter, many targets end up over-filtering 884 # Because of the source assignment filter, many targets end up over-filtering
890 # their sources if the output directory contains a platform name. Assert that 885 # their sources if the output directory contains a platform name. Assert that
891 # this doesn't happen. http://crbug.com/548283 886 # this doesn't happen. http://crbug.com/548283
892 template("assert_valid_out_dir") { 887 template("assert_valid_out_dir") {
(...skipping 11 matching lines...) Expand all
904 assert(target_name != "") # Mark as used. 899 assert(target_name != "") # Mark as used.
905 sources = invoker.actual_sources 900 sources = invoker.actual_sources
906 assert( 901 assert(
907 sources == invoker.actual_sources, 902 sources == invoker.actual_sources,
908 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 903 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
909 } 904 }
910 905
911 assert_valid_out_dir("_unused") { 906 assert_valid_out_dir("_unused") {
912 actual_sources = [ "$root_build_dir/foo" ] 907 actual_sources = [ "$root_build_dir/foo" ]
913 } 908 }
OLDNEW
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698