Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 1875593003: Revert of Store the list of trial tokens in OriginTrialContext (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chasej+watch_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Store the list of trial tokens in OriginTrialContext (patchset #6 id:140001 of https://codereview.chromium.org/1833063002/ ) Reason for revert: Broke release component builds on Windows Original issue's description: > Store the list of trial tokens in OriginTrialContext > > Refactor the way tokens are found by storing them separately from the > document tree in OriginTrialContext. > > This simplifies the architecture a bit, making it easier to: > - add support for tokens specified in http headers. > - add support for trials in workers. > - somehow limit which tokens are considered "valid". > > BUG=601108 > > Committed: https://crrev.com/b03579678fa2678748d5cbcec2e18a8a08e40701 > Cr-Commit-Position: refs/heads/master@{#385504} TBR=iclelland@chromium.org,rbyers@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -113 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js View 1 chunk +15 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl View 1 chunk +38 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/OriginTrials.h.tmpl View 1 chunk +28 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/origin_trials/DocumentOriginTrialContext.h View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/origin_trials/DocumentOriginTrialContext.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/origin_trials/DocumentOriginTrialContextTest.cpp View 1 chunk +117 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 4 chunks +20 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 6 chunks +16 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp View 3 chunks +49 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPNames.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Nico
Created Revert of Store the list of trial tokens in OriginTrialContext
4 years, 8 months ago (2016-04-08 01:49:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875593003/1
4 years, 8 months ago (2016-04-08 01:49:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875593003/1
4 years, 8 months ago (2016-04-08 02:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875593003/1
4 years, 8 months ago (2016-04-08 02:32:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875593003/1
4 years, 8 months ago (2016-04-08 03:02:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/209266)
4 years, 8 months ago (2016-04-08 03:19:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875593003/1
4 years, 8 months ago (2016-04-08 04:44:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/166206) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 04:50:30 UTC) #11
iclelland
On 2016/04/08 04:50:30, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-08 13:34:51 UTC) #12
hans
4 years, 8 months ago (2016-04-08 15:37:11 UTC) #13
On 2016/04/08 13:34:51, iclelland wrote:
> On 2016/04/08 04:50:30, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> >   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Looks like an ASSERT got changed to a DCHECK in Document.h in the meantime, so
> the patch is failing. thakis@ - Is the original patch still in need of a
revert?
> (I don't see windows build failures in the waterfall, but I don't see an
> explicit component buildbot either)

shinyak fixed in https://codereview.chromium.org/1863323004

Powered by Google App Engine
This is Rietveld 408576698