Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1875583002: Revert of Include class relationship diagrams in network stack documentation. (Closed)

Created:
4 years, 8 months ago by Randy Smith (Not in Mondays)
Modified:
4 years, 8 months ago
Reviewers:
eroman, mmenke, scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include class relationship diagrams in network stack documentation. (patchset #6 id:100001 of https://codereview.chromium.org/1859793002/ ) Reason for revert: Something is still using the net_docs target, which was removed; builds are failing on the bots (but didn't fail on any try jobs above--see green). Original issue's description: > Include class relationship diagrams in network stack documentation. > > This CL includes class relationship diagrams for most of the > classes mentioned in life_of_a_url_request.md and a sketch of the > object relationships inside socket pools. It also removes the net_docs > target (which wasn't really being used) and adds information for debugging > markdown changes and updating SVG files from dot source. > > BUG=None > R=eroman@chromium.org > R=mmenke@chromium.org > > Committed: https://crrev.com/fb2fd16bec430431971d14658ef3800b23f0ab3f > Cr-Commit-Position: refs/heads/master@{#385934} TBR=eroman@chromium.org,mmenke@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/88c6adb3c6e51ab5d5b9ab8d75d3c373c5f58518 Cr-Commit-Position: refs/heads/master@{#385941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -1281 lines) Patch
M build/gn_migration.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
D net/docs/README.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M net/docs/life-of-a-url-request.md View 2 chunks +0 lines, -45 lines 0 comments Download
D net/docs/pools.dot View 1 chunk +0 lines, -101 lines 0 comments Download
D net/docs/pools.svg View 1 chunk +0 lines, -335 lines 0 comments Download
D net/docs/url_request.dot View 1 chunk +0 lines, -186 lines 0 comments Download
D net/docs/url_request.svg View 1 chunk +0 lines, -594 lines 0 comments Download
M net/net.gyp View 1 chunk +28 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
A net/tools/net_docs/net_docs.py View 1 chunk +123 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Randy Smith (Not in Mondays)
Created Revert of Include class relationship diagrams in network stack documentation.
4 years, 8 months ago (2016-04-08 01:35:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875583002/1
4 years, 8 months ago (2016-04-08 01:35:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 01:36:31 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 02:11:57 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88c6adb3c6e51ab5d5b9ab8d75d3c373c5f58518
Cr-Commit-Position: refs/heads/master@{#385941}

Powered by Google App Engine
This is Rietveld 408576698