Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be res…

Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be reset before parsing each RTCP packet as the parser is shared by all RTCP packets on sender side. This caused the performance regression and potentially video freezing as well.

BUG=600527
Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
(cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)

Committed: https://chromium.googlesource.com/chromium/src/+/e877754f597c1c2fa8ff411be0c2c6ade0cd6c9f

[miu, 2016-04-07 19:16:19]

Description was changed from

==========
Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets
list need to be reset before parsing each RTCP packet as the parser is shared by
all RTCP packets on sender side. This caused the performance regression and
potentially video freezing as well.

BUG=600527

Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
(cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)
==========

to

==========
Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets
list need to be reset before parsing each RTCP packet as the parser is shared by
all RTCP packets on sender side. This caused the performance regression and
potentially video freezing as well.

BUG=600527

Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
(cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)
==========

[miu, 2016-04-07 19:16:19]

miu@chromium.org changed reviewers:
+ xjz@chromium.org

[miu, 2016-04-07 19:16:37]

xjz: FYI--This is the patch for M50 branch.

[miu, 2016-04-07 19:19:31]

Description was changed from

==========
Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets
list need to be reset before parsing each RTCP packet as the parser is shared by
all RTCP packets on sender side. This caused the performance regression and
potentially video freezing as well.

BUG=600527

Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
(cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)
==========

to

==========
Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets
list need to be reset before parsing each RTCP packet as the parser is shared by
all RTCP packets on sender side. This caused the performance regression and
potentially video freezing as well.

BUG=600527

Review URL: https://codereview.chromium.org/1853253003

Cr-Commit-Position: refs/heads/master@{#385046}
(cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57)

Committed:
https://chromium.googlesource.com/chromium/src/+/e877754f597c1c2fa8ff411be0c2...
==========

[miu, 2016-04-07 19:19:33]

Committed patchset #1 (id:1) manually as
e877754f597c1c2fa8ff411be0c2c6ade0cd6c9f.

[xjz, 2016-04-07 19:42:42]

Thanks Yuri! Should we remove the fix for Cst2?

https://codereview.chromium.org/1875433002/diff/1/media/cast/net/rtcp/rtcp_ut...
File media/cast/net/rtcp/rtcp_utility.cc (right):

https://codereview.chromium.org/1875433002/diff/1/media/cast/net/rtcp/rtcp_ut...
media/cast/net/rtcp/rtcp_utility.cc:295:
cast_message_.received_later_frames.clear();
I think this line should be removed, as Cst2 change seems not in yet.

[miu, 2016-04-07 20:42:30]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1869163002/ by miu@chromium.org.

The reason for reverting is: This change needs to be slightly modified since M50
does not have the |received_later_frames| set..