Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1853253003: Reset NACK/ACK list when parsing a new RTCP packet. (Closed)

Created:
4 years, 8 months ago by xjz
Modified:
4 years, 8 months ago
Reviewers:
miu
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be reset before parsing each RTCP packet as the parser is shared by all RTCP packets on sender side. This caused the performance regression and potentially video freezing as well. BUG=600527 Committed: https://crrev.com/411ea14c10f64b67a25985619583a5331e724d57 Cr-Commit-Position: refs/heads/master@{#385046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/cast/net/rtcp/rtcp_utility.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xjz
PTAL
4 years, 8 months ago (2016-04-04 21:56:05 UTC) #2
miu
lgtm
4 years, 8 months ago (2016-04-04 22:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853253003/1
4 years, 8 months ago (2016-04-04 22:10:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 23:21:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 23:23:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/411ea14c10f64b67a25985619583a5331e724d57
Cr-Commit-Position: refs/heads/master@{#385046}

Powered by Google App Engine
This is Rietveld 408576698