Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875363002: [Merge to M50] Enable bootstrapping feature by default. (Closed)

Created:
4 years, 8 months ago by xdai1
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Merge to M50] Enable bootstrapping feature by default. Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. BUG=597039 TBR=dzhioev@chromium.org, achuith@chromium.org, emaxx@chromium.org Review URL: https://codereview.chromium.org/1829453002 Cr-Commit-Position: refs/heads/master@{#383764} (cherry picked from commit cfe59845e307f126b25d555ef576e2968aa5d7b9) Committed: https://chromium.googlesource.com/chromium/src/+/086d377e0758cfdf3976985616f3afaf9940f1a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -76 lines) Patch
M chrome/app/chromeos_strings.grdp View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 7 chunks +27 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 3 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
xdai1
Committed patchset #1 (id:1) manually as 086d377e0758cfdf3976985616f3afaf9940f1a9 (presubmit successful).
4 years, 8 months ago (2016-04-12 00:37:31 UTC) #3
Wez
4 years, 8 months ago (2016-04-14 07:23:56 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1887953002/ by wez@chromium.org.

The reason for reverting is: Appears to have broken PFQ for M50..

Powered by Google App Engine
This is Rietveld 408576698