Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1875343002: Move WTF classes related to typed arrays to wtf/typed_arrays (Closed)

Created:
4 years, 8 months ago by esprehn
Modified:
4 years, 8 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), hongchan, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+fileapi, kinuko+watch, leviw+renderwatch, Mikhail, nhiroki, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Raymond Toy, Stephen Chennney, sof, szager+layoutwatch_chromium.org, tzik, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WTF classes related to typed arrays to wtf/typed_arrays BUG=602508 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/ba6b12d22ba38fdb43702e64a179012e996ee9a0 Cr-Commit-Position: refs/heads/master@{#386579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2468 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayPiece.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMDataView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/Shape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBuffer.h View 1 chunk +0 lines, -227 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBuffer.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferBuilder.h View 1 chunk +0 lines, -119 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferBuilder.cpp View 1 chunk +0 lines, -124 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferBuilderTest.cpp View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferContents.h View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferContents.cpp View 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferView.h View 1 chunk +0 lines, -134 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayBufferView.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayPiece.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/wtf/ArrayPiece.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/Source/wtf/Float32Array.h View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/Source/wtf/Float64Array.h View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/wtf/Int16Array.h View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/Source/wtf/Int32Array.h View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/wtf/Int8Array.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/wtf/IntegralTypedArrayBase.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/wtf/TypedArrayBase.h View 1 chunk +0 lines, -124 lines 0 comments Download
D third_party/WebKit/Source/wtf/Uint16Array.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/wtf/Uint32Array.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/wtf/Uint8Array.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/wtf/Uint8ClampedArray.h View 1 chunk +0 lines, -91 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayPiece.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/ArrayPiece.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Float32Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Float64Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Int16Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Int32Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Int8Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/IntegralTypedArrayBase.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Uint16Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Uint32Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Uint8Array.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/typed_arrays/Uint8ClampedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 6 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875343002/1
4 years, 8 months ago (2016-04-12 00:17:51 UTC) #3
esprehn
4 years, 8 months ago (2016-04-12 00:18:30 UTC) #5
haraken
LGTM (Not related to this CL, core/dom/DOMTypedArray, core/dom/DOMArrayBuffer etc should be removed. They are unnecessary ...
4 years, 8 months ago (2016-04-12 00:24:57 UTC) #6
esprehn
On 2016/04/12 at 00:24:57, haraken wrote: > LGTM > > (Not related to this CL, ...
4 years, 8 months ago (2016-04-12 00:26:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875343002/1
4 years, 8 months ago (2016-04-12 00:26:37 UTC) #10
haraken
> > (Not related to this CL, core/dom/DOMTypedArray, core/dom/DOMArrayBuffer etc > should be removed. They ...
4 years, 8 months ago (2016-04-12 00:46:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/209416)
4 years, 8 months ago (2016-04-12 02:58:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875343002/1
4 years, 8 months ago (2016-04-12 03:05:25 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 04:13:36 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 04:15:28 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba6b12d22ba38fdb43702e64a179012e996ee9a0
Cr-Commit-Position: refs/heads/master@{#386579}

Powered by Google App Engine
This is Rietveld 408576698