src/ia32/disasm-ia32.cc - Issue 1875323002: Fix testing of the VEX.L (128/256-bit) flag in the x64 disassembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/disasm-ia32.cc

Issue 1875323002: Fix testing of the VEX.L (128/256-bit) flag in the x64 disassembler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add me (addaleax@gmail.com) to the AUTHORS file Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/disasm-ia32.cc

diff --git a/src/ia32/disasm-ia32.cc b/src/ia32/disasm-ia32.cc

index 3cd0ac6e52fbe9d20e85faf60311971b80b18488..b84bda7d16221992ef85e4b5c2be6f2b7a3f6d65 100644

--- a/src/ia32/disasm-ia32.cc

+++ b/src/ia32/disasm-ia32.cc

@@ -281,7 +281,7 @@ class DisassemblerIA32 {

bool vex_128() {

DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5);

byte checked = vex_byte0_ == 0xc4 ? vex_byte2_ : vex_byte1_;

- return (checked & 4) != 1;

+ return (checked & 4) == 0;

}

bool vex_none() {

« no previous file with comments | « AUTHORS ('k') | src/x64/disasm-x64.cc » ('j') | no next file with comments »