Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/ia32/disasm-ia32.cc

Issue 1875323002: Fix testing of the VEX.L (128/256-bit) flag in the x64 disassembler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add me (addaleax@gmail.com) to the AUTHORS file Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | src/x64/disasm-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <assert.h> 5 #include <assert.h>
6 #include <stdarg.h> 6 #include <stdarg.h>
7 #include <stdio.h> 7 #include <stdio.h>
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 10
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 kRCL = 2, 274 kRCL = 2,
275 kRCR = 3, 275 kRCR = 3,
276 kSHL = 4, 276 kSHL = 4,
277 KSHR = 5, 277 KSHR = 5,
278 kSAR = 7 278 kSAR = 7
279 }; 279 };
280 280
281 bool vex_128() { 281 bool vex_128() {
282 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5); 282 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5);
283 byte checked = vex_byte0_ == 0xc4 ? vex_byte2_ : vex_byte1_; 283 byte checked = vex_byte0_ == 0xc4 ? vex_byte2_ : vex_byte1_;
284 return (checked & 4) != 1; 284 return (checked & 4) == 0;
285 } 285 }
286 286
287 bool vex_none() { 287 bool vex_none() {
288 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5); 288 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5);
289 byte checked = vex_byte0_ == 0xc4 ? vex_byte2_ : vex_byte1_; 289 byte checked = vex_byte0_ == 0xc4 ? vex_byte2_ : vex_byte1_;
290 return (checked & 3) == 0; 290 return (checked & 3) == 0;
291 } 291 }
292 292
293 bool vex_66() { 293 bool vex_66() {
294 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5); 294 DCHECK(vex_byte0_ == 0xc4 || vex_byte0_ == 0xc5);
(...skipping 1984 matching lines...) Expand 10 before | Expand all | Expand 10 after
2279 fprintf(f, " "); 2279 fprintf(f, " ");
2280 } 2280 }
2281 fprintf(f, " %s\n", buffer.start()); 2281 fprintf(f, " %s\n", buffer.start());
2282 } 2282 }
2283 } 2283 }
2284 2284
2285 2285
2286 } // namespace disasm 2286 } // namespace disasm
2287 2287
2288 #endif // V8_TARGET_ARCH_IA32 2288 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « AUTHORS ('k') | src/x64/disasm-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698