Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left ha…

Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left hand side of the comparison
(the result of parseContentTypeOptionsHeader())

R=jochen@chromium.org
landing at https://codereview.chromium.org/19004003

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153904

[Alexander Potapenko, 2013-07-05 07:38:41]

PTAL

[jochen (gone - plz use gerrit), 2013-07-05 07:43:12]

lgtm

https://codereview.chromium.org/18753002/diff/1002/Source/core/loader/cache/C...
File Source/core/loader/cache/CachedScript.cpp (right):

https://codereview.chromium.org/18753002/diff/1002/Source/core/loader/cache/C...
Source/core/loader/cache/CachedScript.cpp:89: return
!(parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options"))
== ContentTypeOptionsNosniff) ||
MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());
why not just != ?

[Alexander Potapenko, 2013-07-05 07:46:34]

On 2013/07/05 07:43:12, jochen wrote:
> lgtm
> 
>
https://codereview.chromium.org/18753002/diff/1002/Source/core/loader/cache/C...
> File Source/core/loader/cache/CachedScript.cpp (right):
> 
>
https://codereview.chromium.org/18753002/diff/1002/Source/core/loader/cache/C...
> Source/core/loader/cache/CachedScript.cpp:89: return
>
!(parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options"))
> == ContentTypeOptionsNosniff) ||
> MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());
> why not just != ?

My bad. Fixed.

[commit-bot: I haz the power, 2013-07-05 07:47:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/18753002/8001

[commit-bot: I haz the power, 2013-07-05 08:12:40]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Alexander Potapenko, 2013-07-05 09:24:45]

On 2013/07/05 08:12:40, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

Um, I wonder why it doesn't understand the patch needs to be applied to the
Webkit dir.

[commit-bot: I haz the power, 2013-07-09 12:56:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/18753002/16001

[commit-bot: I haz the power, 2013-07-09 13:06:53]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Alexander Potapenko, 2013-07-10 12:59:43]

Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be
applied to the left hand side of the comparison
(the result of parseContentTypeOptionsHeader())

R=jochen@chromium.org

[commit-bot: I haz the power, 2013-07-10 13:00:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/18753002/24001

[commit-bot: I haz the power, 2013-07-10 13:13:04]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-07-10 15:29:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/18753002/32001

[Nico, 2013-07-10 15:41:25]

It seems you created this issue incorrectly somehow. I'll land this for you at
https://codereview.chromium.org/19004003

[Nico, 2013-07-10 16:17:24]

Committed patchset #6 manually as r153904 (presubmit successful).