Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 19004003: Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left ha…

Created:
7 years, 5 months ago by Nico
Modified:
7 years, 5 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix a warning from Clang's -Wlogical-not-parentheses: logical not used to be applied to the left hand side of the comparison (the result of parseContentTypeOptionsHeader()) Patch from Alexander Potapenko <glider@chromium.org>; Original review URL: https://chromiumcodereview.appspot.com/18753002/ TBR=glider

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/loader/cache/CachedScript.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 5 months ago (2013-07-10 15:41:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/19004003/1
7 years, 5 months ago (2013-07-10 15:42:18 UTC) #2
Alexander Potapenko
On 2013/07/10 15:42:18, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 5 months ago (2013-07-10 15:51:09 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 17:15:50 UTC) #4
Failed to apply patch for Source/core/loader/cache/CachedScript.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/cache/CachedScript.cpp
  Hunk #1 FAILED at 86.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/loader/cache/CachedScript.cpp.rej

Patch:       Source/core/loader/cache/CachedScript.cpp
Index: Source/core/loader/cache/CachedScript.cpp
diff --git a/Source/core/loader/cache/CachedScript.cpp
b/Source/core/loader/cache/CachedScript.cpp
index
c580e4ee49ca3ea176482e87722f19da4c5a9c4f..8c2531df22475a21cb154f5a8a8270ca78878604
100644
--- a/Source/core/loader/cache/CachedScript.cpp
+++ b/Source/core/loader/cache/CachedScript.cpp
@@ -86,7 +86,7 @@ const String& CachedScript::script()
 
 bool CachedScript::mimeTypeAllowedByNosniff() const
 {
-    return
!parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options"))
== ContentTypeOptionsNosniff ||
MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());
+    return
parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options"))
!= ContentTypeOptionsNosniff ||
MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());
 }
 
 void CachedScript::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const

Powered by Google App Engine
This is Rietveld 408576698