[Blob] Better error reporting and histograms.

content/browser/bad_message.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_
 #define CONTENT_BROWSER_BAD_MESSAGE_H_
 
 namespace content {
 class BrowserMessageFilter;
 class RenderProcessHost;
@@ skipping 120 matching lines @@
   RDHI_WRONG_STORAGE_PARTITION = 107,
   RDH_INVALID_REQUEST_ID = 108,
   BDH_SERVICE_NOT_ALLOWED_FOR_ORIGIN = 109,
   WSH_SEND_BLOB_DURING_BLOB_SEND = 110,
   WSH_SEND_FRAME_DURING_BLOB_SEND = 111,
   RFH_UNEXPECTED_LOAD_START = 112,
   NMF_INVALID_ARGUMENT = 113,
   RFH_INVALID_ORIGIN_ON_COMMIT = 114,
   BDH_UUID_REGISTERED = 115,
   BDH_CONSTRUCTION_FAILED = 116,
-  BDH_INVALID_OPERATION = 117,
+  BDH_INVALID_REFCOUNT_OPERATION = 117,

[Mark P, 2016/04/11 21:32:39]

I assume this change is just for clarity, right?  It's not actually changing
when enum number 17 is emitted?

+  BDH_INVALID_URL_OPERATION = 118,
 
   // Please add new elements here. The naming convention is abbreviated class
   // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the
   // reason. After making changes, you MUST update histograms.xml by running:
   // "python tools/metrics/histograms/update_bad_message_reasons.py"
   BAD_MESSAGE_MAX
 };
 
 // Called when the browser receives a bad IPC message from a renderer process on
 // the UI thread. Logs the event, records a histogram metric for the |reason|,
 // and terminates the process for |host|.
 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason);
 
 // Called when a browser message filter receives a bad IPC message from a
 // renderer or other child process. Logs the event, records a histogram metric
 // for the |reason|, and terminates the process for |filter|.
 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason);
 
 }  // namespace bad_message
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BAD_MESSAGE_H_