Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 1875213002: 🏣 Stop including .mojom.js files in GN runtime_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: attach bug Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index 14ddb2fa48eb794514d97a2f58a75a7ace652d94..2aac9f130ed720634e31909ca55c620424b6af3a 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -175,7 +175,12 @@ template("mojom") {
if (defined(invoker.testonly)) {
testonly = invoker.testonly
}
- if (defined(invoker.sources) && !defined(invoker.variant)) {
+
+ # TODO(agrieve): Clients should be setting the data field instead of it
+ # being opportunistically set here. In many cases, the .mojom.js is
+ # put in .pak files, where it should instead be listed as an input to
+ # that action rather than a data. http://crbug.com/603212
+ if (!is_android && defined(invoker.sources) && !defined(invoker.variant)) {
data = process_file_template(invoker.sources, generator_js_outputs)
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698